Draft
Conversation
Merging this PR will degrade performance by 20.33%
Performance Changes
Comparing 
Footnotes
|
a10y
force-pushed
the
aduffy/lazy-patches
branch
2 times, most recently
from
1d28e78 to
65d8c10
Compare
a10y
force-pushed
the
aduffy/patched-array
branch
from
860cc64 to
042394b
Compare
a10y
force-pushed
the
aduffy/lazy-patches
branch
3 times, most recently
from
c76f6bd to
93e2785
Compare
a10y
changed the title
a10y
force-pushed
the
aduffy/lazy-patches
branch
from
93e2785 to
dd20d70
Compare
a10y
force-pushed
the
aduffy/patched-array
branch
from
042394b to
aa8f05f
Compare
a10y
force-pushed
the
aduffy/lazy-patches
branch
2 times, most recently
from
b7c14f1 to
69ce351
Compare
a10y
force-pushed
the
aduffy/patched-array
branch
2 times, most recently
from
df8dbf5 to
862d814
Compare
a10y
force-pushed
the
aduffy/lazy-patches
branch
2 times, most recently
from
0d703d8 to
e658811
Compare
a10y
force-pushed
the
aduffy/patched-array
branch
4 times, most recently
from
ad0eaa7 to
f3d9155
Compare
a10y
force-pushed
the
aduffy/lazy-patches
branch
from
e658811 to
c709a61
Compare
this lets us deserialize BPArray with Patches without eagerly transposing Signed-off-by: Andrew Duffy <andrew@a10y.dev>
This lets us return something other than the original array encoding at read time. Currently we'll want this so that BitPacked::build returns a LazyPatched, but this is applicable for pretty much any back-compat preserving encoding rewrites. Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/lazy-patches
branch
from
c709a61 to
786b70c
Compare
a10y
commented
Apr 1, 2026
| } | ||
| } | ||
|
|
||
| #[cfg(test)] |
removes both the patches field as well as all code for handling patches. this is safe to do now that we have updated the VTable build function to always read methods. note that we need to leave the metadata as-is. Signed-off-by: Andrew Duffy <andrew@a10y.dev>
a10y
force-pushed
the
aduffy/lazy-patches
branch
from
786b70c to
595fd92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #6535 epic and successor to #7002
This wires PatchedArray through to BitPackedArray, replacing the interior Patches entirely. This change is backward compatible.
API Changes
VTable::buildto returnArrayRefinstead ofV::Array. This allows us to lazily deserialize a previously written value as a new type in a backward-compatible wayLazyPatchedArraywhich is just a dummy node that holds on to an array and somePatches, has no reductions and can just be executed into a transposedPatchedArraypatcheschild fromBitPackedArrayBitPackedArray::encode()and a mess of other functions, instead moving everything into a newBitPackedEncoderfluent APITesting
Reuses our existing and extensive test suite for BP